Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2121
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2121/1
Fix member variables not initialized in constructor
Change-Id: I17275e7e17f76da967d2fa798f5ee88b50fd6d72
---
M slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
M slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.hxx
M slideshow/source/engine/OGLTrans/win/OGLTrans_TransitionImpl.hxx
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
index f2c6911..d67fdc7 100644
--- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
+++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx
@@ -379,7 +379,7 @@
virtual void interpolate(double t,double SlideWidthScale,double SlideHeightScale) const = 0;
protected:
- Operation(){}
+ Operation():bInterpolate(false), nT0(0.0), nT1(0.0){}
};
/** this class is a generic CounterClockWise(CCW) rotation with an axis angle
diff --git a/slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.hxx
b/slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.hxx
index 5f21831..983c6bd 100644
--- a/slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.hxx
+++ b/slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.hxx
@@ -283,7 +283,7 @@
class Operation
{
public:
- Operation(){}
+ Operation():bInterpolate(false), nT0(0.0), nT1(0.0){}
virtual ~Operation(){}
/** Should this operation be interpolated . If TRUE, the transform will smoothly move from
making no difference from t = 0.0 to nT0 to being completely transformed from t = nT1 to 1. If
FALSE, the transform will be inneffectual from t = 0 to nT0, and completely transformed from t =
nT0 to 1.
diff --git a/slideshow/source/engine/OGLTrans/win/OGLTrans_TransitionImpl.hxx
b/slideshow/source/engine/OGLTrans/win/OGLTrans_TransitionImpl.hxx
index b61e73a..e64f9965 100644
--- a/slideshow/source/engine/OGLTrans/win/OGLTrans_TransitionImpl.hxx
+++ b/slideshow/source/engine/OGLTrans/win/OGLTrans_TransitionImpl.hxx
@@ -290,7 +290,7 @@
class Operation
{
public:
- Operation(){}
+ Operation():bInterpolate(false), nT0(0.0), nT1(0.0){}
virtual ~Operation(){}
/** Should this operation be interpolated . If TRUE, the transform will smoothly move from
making no difference from t = 0.0 to nT0 to being completely transformed from t = nT1 to 1. If
FALSE, the transform will be inneffectual from t = 0 to nT0, and completely transformed from t =
nT0 to 1.
--
To view, visit https://gerrit.libreoffice.org/2121
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17275e7e17f76da967d2fa798f5ee88b50fd6d72
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412@yahoo.fr>
Context
- [PATCH] Fix member variables not initialized in constructor · Julien Nabet (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.