Re: [Libreoffice-commits] core.git: 3 commits - android/sdremote l10ntools/source

Thorsten Behrens <thb -AT- documentfoundation.org>

Tue, 12 Feb 2013 01:03:30 +0100

gerrit wrote:

index 71909d9..26aabcb 100644
--- a/l10ntools/source/stringmerge.cxx
+++ b/l10ntools/source/stringmerge.cxx
@@ -161,6 +161,7 @@ void StringParser::Merge(
             {
                 OString sNewText;
                 pEntrys->GetText( sNewText, STRING_TYP_TEXT, m_sLang );
+                sNewText = 
sNewText.replaceAll("\"","&quot;").replaceAll("\\\\\"","\\\"").replaceAll("\'","&apos;").replaceAll("\\\\\'","\\\'");
                 xmlNodeSetContent(
                     pCurrent,
                     xmlEncodeSpecialChars( NULL,

This one is actually broken - xmlNodeSetContent already does the necessary escaping of entities, in this case " etc gets turned into &quot;. Updated the Impress Remote regardless (as having localized UI there is still worthwhile), will look after a proper fix tomorrow. Cheers, -- Thorsten

Attachment: signature.asc
Description: Digital signature

Context

Re: [Libreoffice-commits] core.git: 3 commits - android/sdremote l10ntools/source · Thorsten Behrens

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.