Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2049

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/2049/1

translate German comments, remove obsolete code

Change-Id: I4d6e3149f94234e2b884ab81e752805d07a63712
---
M sw/source/core/view/viewimp.cxx
1 file changed, 115 insertions(+), 97 deletions(-)



diff --git a/sw/source/core/view/viewimp.cxx b/sw/source/core/view/viewimp.cxx
index 6b114a2..8ae0086 100644
--- a/sw/source/core/view/viewimp.cxx
+++ b/sw/source/core/view/viewimp.cxx
@@ -43,18 +43,20 @@
 #include <IDocumentDeviceAccess.hxx>
 #include <IDocumentSettingAccess.hxx>
 
-/*************************************************************************
-|*
-|*  SwViewImp::Init()
-|*
-|*  Ersterstellung      MA 25. Jul. 94
-|*  Letzte Aenderung    MA 03. Nov. 95
-|*
-|*************************************************************************/
+/**
+
+  SwViewImp::Init()
+
+  Created      MA 25. Jul. 94
+  Last change  MA 03. Nov. 95
+
+  @author MA
+
+*/
 void SwViewImp::Init( const SwViewOption *pNewOpt )
 {
     OSL_ENSURE( pDrawView, "SwViewImp::Init without DrawView" );
-    //Jetzt die PageView erzeugen wenn sie noch nicht existiert.
+    //Create PageView if it doesn't exist
     SwRootFrm *pRoot = pSh->GetLayout();    //swmod 071108//swmod 071225
     if ( !pSdrPageView )
     {
@@ -95,14 +97,16 @@
     pDrawView->SetMarkHdlSizePixel(9);
 }
 
-/*************************************************************************
-|*
-|*  SwViewImp::SwViewImp()  CTor fuer die Core-Internas
-|*
-|*  Ersterstellung      MA 25. Jul. 94
-|*  Letzte Aenderung    MA 06. Sep. 96
-|*
-|*************************************************************************/
+/**
+
+  SwViewImp::SwViewImp()  CTor for the core internals
+
+  Created      MA 25. Jul. 94
+  Last change  MA 06. Sep. 96
+
+  @author MA
+
+*/
 
 SwViewImp::SwViewImp( ViewShell *pParent ) :
     pSh( pParent ),
@@ -118,21 +122,21 @@
     // OD 12.12.2002 #103492#
     mpPgPrevwLayout( 0 )
 {
-    //bResetXorVisibility =
-    //HMHbShowHdlPaint =
     bResetHdlHiddenPaint =
     bSmoothUpdate = bStopSmooth = bStopPrt = sal_False;
     bFirstPageInvalid = sal_True;
 }
 
-/******************************************************************************
-|*
-|*  SwViewImp::~SwViewImp()
-|*
-|*  Ersterstellung      MA 25. Jul. 94
-|*  Letzte Aenderung    MA 16. Dec. 94
-|*
-******************************************************************************/
+/**
+
+  SwViewImp::~SwViewImp()
+
+  Created      MA 25. Jul. 94
+  Last change  MA 16. Dec. 94
+
+  @author MA
+
+*/
 
 SwViewImp::~SwViewImp()
 {
@@ -141,7 +145,7 @@
     // OD 12.12.2002 #103492#
     delete mpPgPrevwLayout;
 
-    //JP 29.03.96: nach ShowSdrPage muss auch HideSdrPage gemacht werden!!!
+    //JP 29.03.96: after ShowSdrPage  HideSdrPage must also be executed!!!
     if( pDrawView )
          pDrawView->HideSdrPage();
 
@@ -153,28 +157,32 @@
     OSL_ENSURE( !pIdleAct,"Be idle for the rest of your life." );
 }
 
-/******************************************************************************
-|*
-|*  SwViewImp::DelRegions()
-|*
-|*  Ersterstellung      MA 14. Apr. 94
-|*  Letzte Aenderung    MA 14. Apr. 94
-|*
-******************************************************************************/
+/**
+
+  SwViewImp::DelRegions()
+
+  Created      MA 14. Apr. 94
+  Last change  MA 14. Apr. 94
+
+  @author MA
+
+*/
 
 void SwViewImp::DelRegion()
 {
     DELETEZ(pRegion);
 }
 
-/******************************************************************************
-|*
-|*  SwViewImp::AddPaintRect()
-|*
-|*  Ersterstellung      MA ??
-|*  Letzte Aenderung    MA 27. Jul. 94
-|*
-******************************************************************************/
+/**
+
+  SwViewImp::AddPaintRect()
+
+  Created      MA ??
+  Last change  MA 27. Jul. 94
+
+  @author MA
+
+*/
 
 sal_Bool SwViewImp::AddPaintRect( const SwRect &rRect )
 {
@@ -188,14 +196,16 @@
     return sal_False;
 }
 
-/******************************************************************************
-|*
-|*  ViewImp::CheckWaitCrsr()
-|*
-|*  Ersterstellung      MA 10. Aug. 94
-|*  Letzte Aenderung    MA 10. Aug. 94
-|*
-******************************************************************************/
+/**
+
+  ViewImp::CheckWaitCrsr()
+
+  Created      MA 10. Aug. 94
+  Last change  MA 10. Aug. 94
+
+  @author MA
+
+*/
 
 void SwViewImp::CheckWaitCrsr()
 {
@@ -203,14 +213,16 @@
         pLayAct->CheckWaitCrsr();
 }
 
-/******************************************************************************
-|*
-|*  ViewImp::IsCalcLayoutProgress()
-|*
-|*  Ersterstellung      MA 12. Aug. 94
-|*  Letzte Aenderung    MA 12. Aug. 94
-|*
-******************************************************************************/
+/**
+
+  ViewImp::IsCalcLayoutProgress()
+
+  Created      MA 12. Aug. 94
+  Last change  MA 12. Aug. 94
+
+  @author MA
+
+*/
 
 sal_Bool SwViewImp::IsCalcLayoutProgress() const
 {
@@ -219,14 +231,16 @@
     return sal_False;
 }
 
-/******************************************************************************
-|*
-|*  ViewImp::IsUpdateExpFlds()
-|*
-|*  Ersterstellung      MA 28. Mar. 96
-|*  Letzte Aenderung    MA 28. Mar. 96
-|*
-******************************************************************************/
+/**
+
+  ViewImp::IsUpdateExpFlds()
+
+  Created      MA 28. Mar. 96
+  Last change  MA 28. Mar. 96
+
+  @author MA
+
+*/
 
 sal_Bool SwViewImp::IsUpdateExpFlds()
 {
@@ -239,23 +253,24 @@
 }
 
 
-/******************************************************************************
-|*
-|*  SwViewImp::SetFirstVisPage(), ImplGetFirstVisPage();
-|*
-|*  Ersterstellung      MA 21. Sep. 93
-|*  Letzte Aenderung    MA 08. Mar. 94
-|*
-******************************************************************************/
+/**
+
+  SwViewImp::SetFirstVisPage(), ImplGetFirstVisPage();
+
+  Created      MA 21. Sep. 93
+  Last change  MA 08. Mar. 94
+
+  @author MA
+
+*/
 
 void SwViewImp::SetFirstVisPage()
 {
     if ( pSh->bDocSizeChgd && pSh->VisArea().Top() > pSh->GetLayout()->Frm().Height() )
     {
-        //Wir stecken in einer Action und die VisArea sitzt wegen
-        //Loeschoperationen hinter der erste sichtbaren Seite.
-        //Damit nicht zu heftig Formatiert wird, liefern wir die letzte Seite
-        //zurueck.
+        //We are in an action and because of erase actions the VisArea is
+        //after the first visible page.
+        //To avoid excessive formatting, hand back the last page.
         pFirstVisPage = (SwPageFrm*)pSh->GetLayout()->Lower();
         while ( pFirstVisPage && pFirstVisPage->GetNext() )
             pFirstVisPage = (SwPageFrm*)pFirstVisPage->GetNext();
@@ -285,14 +300,16 @@
     bFirstPageInvalid = sal_False;
 }
 
-/******************************************************************************
-|*
-|*  SwViewImp::MakeDrawView();
-|*
-|*  Ersterstellung      AMA 01. Nov. 95
-|*  Letzte Aenderung    AMA 01. Nov. 95
-|*
-******************************************************************************/
+/**
+
+  SwViewImp::MakeDrawView();
+
+  Created      AMA 01. Nov. 95
+  Last change  AMA 01. Nov. 95
+
+  @author AMA
+
+*/
 
 void SwViewImp::MakeDrawView()
 {
@@ -318,7 +335,6 @@
 
             if(!pOutDevForDrawView)
             {
-                // pOutDevForDrawView = 
(OutputDevice*)GetShell()->getIDocumentDeviceAccess()->getPrinter( false );
                 pOutDevForDrawView = GetShell()->GetOut();
             }
 
@@ -341,14 +357,16 @@
     }
 }
 
-/******************************************************************************
-|*
-|*  SwViewImp::GetRetoucheColor()
-|*
-|*  Ersterstellung      MA 24. Jun. 98
-|*  Letzte Aenderung    MA 24. Jun. 98
-|*
-******************************************************************************/
+/**
+
+  SwViewImp::GetRetoucheColor()
+
+  Created      MA 24. Jun. 98
+  Last change  MA 24. Jun. 98
+
+  @author MA
+
+*/
 
 Color SwViewImp::GetRetoucheColor() const
 {

-- 
To view, visit https://gerrit.libreoffice.org/2049
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d6e3149f94234e2b884ab81e752805d07a63712
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Winfried Donkers <osc@dci-electronics.nl>

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.