Re: Moving Code From /core/sw... to /core/vcl

On Wed, Feb 6, 2013 at 3:37 PM, Caolán McNamara <caolanm@redhat.com> wrote:

> On Mon, 2013-02-04 at 11:18 +0100, Jan Holesovsky wrote:
> > The code responsible for all this seems unnecessarily complicated to me,
> > so I am sorry if my quick read is actually misleading - but in general,
> > you don't want to move parts of sw/ to vcl, more so if it meant
> > including headers from sw in vcl.
>
> Yeah, I wanted to give this a proper look, but never carved out the
> time, short answer is that what we want to happen is roughly
> a) remove that implicit store of settings in the writer code where it
> happens as a side effect and get it called explicitly in some store
> options configuration e.g.
> in PrintDialog::storeToSettings have a maPController->storeUIOptions();
> call and that maPController fundamentally comes from
> new SfxPrinterController in sfx2/source/view/viewprn.cxx and takes a
> SfxViewShell as an argument so it should be possible somewhere around
> there to add a virtual storeUIOptions to the vcl::PrinterController,
> implement it in SfxPrinterController and propagate (here its the usual
> frustrating haze of "shells") the task to yet-another app-specific
> virtual store method and move the writer implicit-save code into that
> method instead.
>
> C.

Thanks to both of you for the pointers. I'm hesitant to tackle this now as
it seems well beyond my ability but....we'll see if I can find a friend or
family member to do it with me.

Best Regards,
Joel


-- 
*Joel Madero*
LibreOffice QA Volunteer
jmadero.dev@gmail.com