Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2015

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2015/1

Remove useless function calls.

nPos has already been computed the 3 lines above. No need to recompute it.

Change-Id: Iad739d6fffd2c40cc633789edfe88d13e87dd28b
Signed-off-by: jailletc36 <christophe.jaillet@wanadoo.fr>
---
M sc/source/ui/optdlg/opredlin.cxx
1 file changed, 0 insertions(+), 4 deletions(-)



diff --git a/sc/source/ui/optdlg/opredlin.cxx b/sc/source/ui/optdlg/opredlin.cxx
index 6badae1..cf4b486 100644
--- a/sc/source/ui/optdlg/opredlin.cxx
+++ b/sc/source/ui/optdlg/opredlin.cxx
@@ -89,7 +89,6 @@
     nPos = aContentColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aContentColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aContentColorLB.GetEntryColor(nPos).GetColor();
         else
@@ -101,7 +100,6 @@
     nPos = aMoveColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aMoveColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aMoveColorLB.GetEntryColor(nPos).GetColor();
         else
@@ -113,7 +111,6 @@
     nPos = aInsertColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aInsertColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aInsertColorLB.GetEntryColor(nPos).GetColor();
         else
@@ -125,7 +122,6 @@
     nPos = aRemoveColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aRemoveColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aRemoveColorLB.GetEntryColor(nPos).GetColor();
         else

-- 
To view, visit https://gerrit.libreoffice.org/2015
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad739d6fffd2c40cc633789edfe88d13e87dd28b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.