On Tue, 2013-02-05 at 14:26 -0800, julien2412 wrote:
Hello,
Cppcheck detected this:
sc/source/core/data/table5.cxx
147 unreadVariable style Variable 'bSkipBreaks' is assigned a value that is
never used.
Hmm, I reckon kohei should have a look at that. bSkipBreaks doesn't go
anywhere so its doing nothing. git blame shows d8c68b41b and references
#i94698 and looking at the context of the original patch there it seems
that back then there was only a single "bSkipBreaks" bool while now
there are two, bSkipColBreaks and bSkipRowBreaks.
Presumably somewhere along the go-ooo time
sc-fit-to-width-height-skip-breaks.diff didn't apply after bSkipBreaks
got split into bSkipColBreaks and bSkipRowBreaks and the fixup didn't
take account of that.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.