Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On 01/31/2013 01:58 AM, Michael Meeks wrote:
On Wed, 2013-01-30 at 16:26 +0100, Stephan Bergmann wrote:
      fix for the awkward OUString::replaceAll() behaviour

Seeing this, that's the reason I've always been unhappy with such a
replaceAll function:  While it may appear "obviously useful," it easily
leads to broken code (like if rInfo1 is "wanna bet $2 this doesn't
work?", say, in the above snippet).

        We could deprecate it. Do we have a nice macro wrapped around some
magic gcc: "really warn if return value unused" attribute - I assume
there is one of those - that might help make it more sane ?

You missed my point, which was not the gotcha of ignoring the return value (which is already addressed with SAL_WARN_UNUSED_RESULT anyway), but the gotcha that a sequence of replaceAll calls to replace multiple placeholders with corresponding replacement values is broken in general (unless you can ensure that each invocation in the sequence does not introduce new instances of "subsequent" placeholders into the operated-upon string).

Stephan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.