Re: [REVIEW 4-0-0 2/3] ... sdremote foo ...

On Mon, 2013-01-28 at 18:05 +0100, Stephan Bergmann wrote:
> As I said at <https://bugs.freedesktop.org/show_bug.cgi?id=59881#c6>, 
> comment 6 to "sdremote - deadlock ...," it would probably make more 
> sense "to dispatch events into the VCL event loop from 
> sd::Communicator::execute, instead of going via a timer," but I can sure 
> give a rubber-stamp +1 to this fix for -4-0-0, anyway.  One more needed.

        Quite right - I have another commit we should bundle into this one (and
also pick to -4-0) that removes that pieces - it's no longer necessary
if we do everything in the main thread; so it looks like we need:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab8e37573628f2e5863e7fc0252103ab32203fc2

        and Lubos's SAL_CALL cleanup:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0&id=88cb36db72775c116c4721163763beb1b2ec0ea3

        in both -4-0 and 4-0-0.

        Thanks !

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot