Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On Saturday 19 of January 2013, julien2412 wrote:
Hello,

Here's a problem in stoc/test/testintrosp.cxx, line 182
aRetStr = aRetStr + OUString( OUString(" (Typ: ") ) + xIdlClass->getName()
+ OUString(""));

By taking a look at git history, I found that it was:
aRetStr = aRetStr + OUString( OUString(RTL_CONSTASCII_USTRINGPARAM(" (Typ:
")) ) + xIdlClass->getName() + OUString(RTL_CONSTASCII_USTRINGPARAM(")"));
before 02/06/2012

 Presumably whoever did this used regular expressions to do the change and 
didn't get this one quite right.

If testintrosp.cxx is still used, an idea how to make this line more clear
(and perhaps removing the double use of OUString)?

 aRetStr += " (Typ: " + xIdlClass->getName() + ")";

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.