Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1778

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1778/1

don't create multiple dialogs in the loop, fdo#59314

Change-Id: Ia48262cdf8b07caf6622f2d4a48f366f3f26c0fd
---
M sc/source/ui/view/cellsh1.cxx
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 68be16dd..2227c19 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -1805,6 +1805,7 @@
                             // found a matching range, edit this conditional format
                             nKey = pCondFormat->GetKey();
                             pCondFormatDlg.reset( new ScCondFormatDlg( 
pTabViewShell->GetDialogParent(), pDoc, pCondFormat, rCondFormatRange, aPos, 
condformat::dialog::NONE ) );
+                            break;
                         }
                     }
 

-- 
To view, visit https://gerrit.libreoffice.org/1778
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia48262cdf8b07caf6622f2d4a48f366f3f26c0fd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard <markus.mohrhard@googlemail.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.