Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1773
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1773/1
Remove some unneeded variables in filter
Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
---
M filter/source/graphicfilter/eps/eps.cxx
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/filter/source/graphicfilter/eps/eps.cxx b/filter/source/graphicfilter/eps/eps.cxx
index 9405328..58c56f5 100644
--- a/filter/source/graphicfilter/eps/eps.cxx
+++ b/filter/source/graphicfilter/eps/eps.cxx
@@ -298,26 +298,21 @@
if( pResMgr )
{
- String aPreviewStr( "Preview" );
- String aVersionStr( "Version" );
- String aColorStr( "ColorFormat" );
- String aComprStr( "CompressionMode" );
#ifdef UNX // don't put binary tiff preview ahead of postscript code by default on unix as
ghostscript is unable to read it
- mnPreview = pFilterConfigItem->ReadInt32( aPreviewStr, 0 );
+ mnPreview = pFilterConfigItem->ReadInt32( "Preview", 0 );
#else
- mnPreview = pFilterConfigItem->ReadInt32( aPreviewStr, 1 );
+ mnPreview = pFilterConfigItem->ReadInt32( "Preview", 1 );
#endif
- mnLevel = pFilterConfigItem->ReadInt32( aVersionStr, 2 );
+ mnLevel = pFilterConfigItem->ReadInt32( "Version", 2 );
if ( mnLevel != 1 )
mnLevel = 2;
- mbGrayScale = pFilterConfigItem->ReadInt32( aColorStr, 1 ) == 2;
+ mbGrayScale = pFilterConfigItem->ReadInt32( "ColorFormat", 1 ) == 2;
#ifdef UNX // don't compress by default on unix as ghostscript is unable to read LZW compressed eps
- mbCompression = pFilterConfigItem->ReadInt32( aComprStr, 0 ) != 0;
+ mbCompression = pFilterConfigItem->ReadInt32( "CompressionMode", 0 ) != 0;
#else
- mbCompression = pFilterConfigItem->ReadInt32( aComprStr, 1 ) == 1;
+ mbCompression = pFilterConfigItem->ReadInt32( "CompressionMode", 1 ) == 1;
#endif
- String sTextMode( "TextMode" );
- mnTextMode = pFilterConfigItem->ReadInt32( sTextMode, 0 );
+ mnTextMode = pFilterConfigItem->ReadInt32( "TextMode", 0 );
if ( mnTextMode > 2 )
mnTextMode = 0;
delete pResMgr;
--
To view, visit https://gerrit.libreoffice.org/1773
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza <marcos.souza.org@gmail.com>
Context
- [PATCH] Remove some unneeded variables in filter · Marcos Souza (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.