Re: [PATCH] Consolidated branding in configure

Hello

This is a proposal with many goals:
1- lessen configure options
2- consolidate default values locations
3- consolidate data origin

1- This patch will remove
--with-intro*,--with-startcenter*,--with-about-background-svg,--with-flat-logo-svg
and will expand --with-branding to this regard

2- In configure.ac, we set default settings for PROGRESSBARCOLOR
PROGRESSSIZE
PROGRESSPOSITION PROGRESSFRAMECOLOR PROGRESSTEXTCOLOR PROGRESSTEXTBASELINE.
The 4 first are also defined with Globals in
instsetoo_native/util/openoffice.lst, but with different values.
Since configure values only purpose is to override the ones in
openoffice.lst, I moved PROGRESSTEXTCOLOR PROGRESSTEXTBASELINE to it,
and remove default values from configure

3- The rationale here is that all these options are mostly related. Moving
some settings to a text file could look weird but is sensible in the way
they are often (> 99%) related to the delivery of alternate pictures. So
all pictures and progress bar settings go in the same directory and that's
it.

I am conscious there may be some work for distros-maintainers, but i think
it is a good trade-off.
And more, if this is accepted, there may be some consolidation in the
scripts that handle filenames since they all are standardized with this
patch.

Regards


Le Wed, 16 Jan 2013 00:43:59 +0100, Mathias M (via Code Review)
<gerrit@gerrit.libreoffice.org> a écrit:

> Hi,
>
> I have submitted a patch for review:
>
>     https://gerrit.libreoffice.org/1704
>
> To pull it, you can do:
>
>     git pull ssh://gerrit.libreoffice.org:29418/core  
> refs/changes/04/1704/1
>
> Consolidated branding in configure
>
> Removed individual options (intro* and startcenter* + images) in favor  
> of a folder with graceful fallback.
> Grouped progress bar intro settings in a text file into the branding  
> folder
>
> Change-Id: Ib56b80e43c474a944ac79c0a842d66487e9f91d5
> ---
> M configure.ac
> M instsetoo_native/util/openoffice.lst.in
> 2 files changed, 81 insertions(+), 303 deletions(-)



--
Mat M