Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1654
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1654/1
Let's not return here to prevent memory leak.
There are several heap objects that are deleted at the end of the
method. Returning prematurely would leak those objects.
Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
---
M sc/source/ui/docshell/dbdocfun.cxx
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx
index 5216c68..9fea320 100644
--- a/sc/source/ui/docshell/dbdocfun.cxx
+++ b/sc/source/ui/docshell/dbdocfun.cxx
@@ -1330,8 +1330,7 @@
if ( pDestObj )
{
pDestObj->ReloadGroupTableData();
- if (!pDestObj->SyncAllDimensionMembers())
- return false;
+ pDestObj->SyncAllDimensionMembers();
pDestObj->InvalidateData(); // before getting the new output area
// make sure the table has a name (not set by dialog)
--
To view, visit https://gerrit.libreoffice.org/1654
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Kohei Yoshida <kohei.yoshida@gmail.com>
Context
- [PATCH] Change in core[libreoffice-3-6]: Let's not return here to prevent memory leak. · Kohei Yoshida (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.