On Thursday 10 of January 2013, Matúš Kukan wrote:
On 10 January 2013 09:16, Stephan Bergmann <sbergman@redhat.com> wrote:
Ah, so Petr's "IMHO, it would make sense to use CXXFLAGS after the
default global flags but before the source file specific flags" sounds
reasonable to me.
See https://gerrit.libreoffice.org/#/c/1632/ for a reasonable easy way
to do this.
It should work, etc.
But it may break PCH_CXXFLAGS. I don't feel like testing --enable-pch
build.
- for PCH gb_CxxObject__set_pchflags should be modified too.
- shouldn't the new flags be initialized in gb_LinkTarget_LinkTarget?
- (as a general rule) for non-obvious commits, please include in the commit
log message not only what but also why, such as a link to this thread. In a
year somebody's bound to want to reshuffle the flags and wonder about the
commit.
--
Lubos Lunak
l.lunak@suse.cz
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.