Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1523
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1523/1
Minimal fix fdo#58766 Macro Recorder opt not saved
Load of the last Misc. config item is skipped due to
its index == # of strings in array in GetPropertyNames.
Omission in middle drops last item -
never gets to the Enable Macro Recorder option.
Change-Id: If99e0aa89e82ffc362f5e4bda712881a546e510a
---
M svtools/source/config/miscopt.cxx
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/svtools/source/config/miscopt.cxx b/svtools/source/config/miscopt.cxx
index c3666d0..d79ad29 100644
--- a/svtools/source/config/miscopt.cxx
+++ b/svtools/source/config/miscopt.cxx
@@ -43,28 +43,29 @@
#define ASCII_STR(s) OUString( RTL_CONSTASCII_USTRINGPARAM(s) )
#define ROOTNODE_MISC ASCII_STR("Office.Common/Misc")
+// PROPERTYHANDLE defines must be sequential from zero for Commit/Load
#define PROPERTYNAME_PLUGINSENABLED ASCII_STR("PluginsEnabled")
-#define PROPERTYHANDLE_PLUGINSENABLED 0
+#define PROPERTYHANDLE_PLUGINSENABLED 0
#define PROPERTYNAME_SYMBOLSET ASCII_STR("SymbolSet")
-#define PROPERTYHANDLE_SYMBOLSET 1
+#define PROPERTYHANDLE_SYMBOLSET 1
#define PROPERTYNAME_TOOLBOXSTYLE ASCII_STR("ToolboxStyle")
-#define PROPERTYHANDLE_TOOLBOXSTYLE 2
+#define PROPERTYHANDLE_TOOLBOXSTYLE 2
#define PROPERTYNAME_USESYSTEMFILEDIALOG ASCII_STR("UseSystemFileDialog")
-#define PROPERTYHANDLE_USESYSTEMFILEDIALOG 3
+#define PROPERTYHANDLE_USESYSTEMFILEDIALOG 3
#define PROPERTYNAME_SYMBOLSTYLE ASCII_STR("SymbolStyle")
-#define PROPERTYHANDLE_SYMBOLSTYLE 4
+#define PROPERTYHANDLE_SYMBOLSTYLE 4
#define PROPERTYNAME_USESYSTEMPRINTDIALOG ASCII_STR("UseSystemPrintDialog")
-#define PROPERTYHANDLE_USESYSTEMPRINTDIALOG 5
+#define PROPERTYHANDLE_USESYSTEMPRINTDIALOG 5
#define PROPERTYNAME_SHOWLINKWARNINGDIALOG ASCII_STR("ShowLinkWarningDialog")
-#define PROPERTYHANDLE_SHOWLINKWARNINGDIALOG 7
+#define PROPERTYHANDLE_SHOWLINKWARNINGDIALOG 6
#define PROPERTYNAME_DISABLEUICUSTOMIZATION ASCII_STR("DisableUICustomization")
-#define PROPERTYHANDLE_DISABLEUICUSTOMIZATION 8
+#define PROPERTYHANDLE_DISABLEUICUSTOMIZATION 7
#define PROPERTYNAME_ALWAYSALLOWSAVE ASCII_STR("AlwaysAllowSave")
-#define PROPERTYHANDLE_ALWAYSALLOWSAVE 9
+#define PROPERTYHANDLE_ALWAYSALLOWSAVE 8
#define PROPERTYNAME_EXPERIMENTALMODE ASCII_STR("ExperimentalMode")
-#define PROPERTYHANDLE_EXPERIMENTALMODE 10
+#define PROPERTYHANDLE_EXPERIMENTALMODE 9
#define PROPERTYNAME_MACRORECORDERMODE ASCII_STR("MacroRecorderMode")
-#define PROPERTYHANDLE_MACRORECORDERMODE 11
+#define PROPERTYHANDLE_MACRORECORDERMODE 10
#define VCL_TOOLBOX_STYLE_FLAT ((sal_uInt16)0x0004) // from <vcl/toolbox.hxx>
--
To view, visit https://gerrit.libreoffice.org/1523
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If99e0aa89e82ffc362f5e4bda712881a546e510a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: LeMoyne Castle <lemoyne.castle@gmail.com>
Context
- [PATCH] Minimal fix fdo#58766 Macro Recorder opt not saved · LeMoyne Castle (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.