Re: [PATCH] fdo#38090: vcl: remove ImplFontCache::maFontNameList:

On 20/12/12 11:43, Michael Meeks wrote:
> Hi Michael,
>
> On Wed, 2012-12-19 at 20:19 +0000, Michael Stahl wrote:
> >     https://gerrit.libreoffice.org/1424
> >
> > To pull it, you can do:
> >
> >     git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/1424/1
> >
> > fdo#38090: vcl: remove ImplFontCache::maFontNameList:
> >
> > The font cache in VCL returns different fonts for identical parameters,
> > which causes layout differences in Writer.
>
>       I'm always a bit scared about font caching problems :-) Last I looked
> in this area we had some -hideous- (IIRC an order of magnitude+)
> performance degradation when we turned some related cache in that file
> off for some use-cases:
>
>       https://bugs.freedesktop.org/show_bug.cgi?id=47636
>
>       Indeed it was so bad we had an MAB related to this:
>
>       https://bugs.freedesktop.org/show_bug.cgi?id=44719
>
>       I assume that neither of these come back with the fix ? :-) hopefully
> it is yet-another (different) cache we're talking about there.

it is actually a different cache that is situated _before_ the
maFontInstanceList cache that was tweaked to fix those bugs, though i
have no idea what performance impact this has...

for a quick sanity check i've loaded the bugdoc from fdo#47636 and hit
pagedown until the end, which took (on a remote X display with dbgutil
build) 18 seconds without the change and 16 with, which probably means i
suck at using a stopwatch  :)