Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1256
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1256/1
OUStringBuffer::remove( int ) -> truncate( int )
Although this may seem consistent with remove( int, int ), it is
in fact rather misleading API. The biggest offender is most probably
buffer.remove( 'a' ) , which definitely does not do what it suggests
to do.
Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
---
M sal/inc/rtl/ustrbuf.hxx
M svl/source/numbers/zformat.cxx
M xmloff/source/style/xmlnumfi.cxx
3 files changed, 10 insertions(+), 10 deletions(-)
--
To view, visit https://gerrit.libreoffice.org/1256
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luboš Luňák <l.lunak@suse.cz>
Gerrit-Reviewer: Norbert Thiebaud <nthiebaud@gmail.com>
Context
- [PATCH] OUStringBuffer::remove( int ) -> truncate( int ) · via Code Review
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.