Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 12/04/2012 01:23 PM, Fridrich Strba (via Code Review) wrote:
Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

     https://gerrit.libreoffice.org/1232

Approvals:
   Fridrich Strba: Verified; Looks good to me, approved

Seeing this commit, I note that XPricingFunctions has method identifiers starting with a lower case letter and containing underscores. Such identifiers are reserved to the UNO implementation. (See <http://www.openoffice.org/udk/common/man/typesystem.html>. There is a -w resp. -we switch for idlc to generate warnings resp. errors in such cases, but that is not enabled in our build, because there were some historic violations IIRC.)

Tino, can you adapt XPricingFunctions accordingly?

Eike, my vague understaning of Calc Add-Ins is that they indeed need both a new UNO service and interface definition, right?

Stephan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.