Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hej Miklos,

i added review command to git-review:

https://review.openstack.org/17423

Now you can review gerrit patch without using web browser, and even add multiline comment message in your favorite editor, i guess vim, or whatever GIT_EDITOR is set ;-)

Enjoy
David

-------- Original Message --------
Subject:        [Bug 1021750] Re: add gerrit review command
Date:   Mon, 03 Dec 2012 23:00:33 -0000
From:   OpenStack Hudson <1021750@bugs.launchpad.net>
Reply-To:       Bug 1021750 <1021750@bugs.launchpad.net>
To:     d.ostrovsky@gmx.de



Fix proposed to branch: master
Review: https://review.openstack.org/17423

** Changed in: git-review
       Status: New => In Progress

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1021750

Title:
  add gerrit review command

Status in Git Review:
  In Progress

Bug description:
  it would be nice to have also wraper for gerrit review command:
  http://gerrit-documentation.googlecode.com/svn/Documentation/2.4.2/cmd-review.html

  Because this tool already named review may be it can be renamed to
  git-gerrit.

  The guys from #gerrit freenode channel didn't understand what git-
  review tool all about (as we tried to explain them) and have thought,
  that it can only review the gerrit patches from command line.
  Ironically that featuire ist still missing.

  With this verb review in place (after renaming) the workflow would
  like something like that:

  git gerrit download c0ff33
  look around
  git gerrit review review --code-review +2 c0ff33

  To see how other did it in python:
  https://gitorious.org/querrit/querrit

  and in bash:
  http://cgit.freedesktop.org/libreoffice/core/tree/logerrit

To manage notifications about this bug go to:
https://bugs.launchpad.net/git-review/+bug/1021750/+subscriptions





Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.