Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1165
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/1165/1
fdo#34897 numbers were wrong, code unnecessary
also working, but worse:
if (nAngle==900) {
AddOpt( ESCHER_Prop_txflTextFlow, ESCHER_txflBtoT );
bSuppressRotation=true;
}
if (nAngle==2700) {
AddOpt( ESCHER_Prop_txflTextFlow, ESCHER_txflTtoBA );
bSuppressRotation=true;
}
but: text flow is perhaps not intended to specify rotation, created data may misbehave on
other applications, and there is no reason for this unnecessary special case.
(Especially obvious because there is no text flow that causes 180 deg rotation.)
Change-Id: I0b1cac78e549c2126d7e45298629e28fc76ac95d
Signed-off-by: Lennard <Wasserthal@nefkom.net>
---
M filter/source/msfilter/escherex.cxx
1 file changed, 0 insertions(+), 12 deletions(-)
--
To view, visit https://gerrit.libreoffice.org/1165
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b1cac78e549c2126d7e45298629e28fc76ac95d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lennard Wasserthal <Wasserthal@nefkom.net>
Context
- [PATCH] fdo#34897 numbers were wrong, code unnecessary · Lennard Wasserthal (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.