Re: [REVIEW 3-6-4 2/3] fix for fdo#57451, don't throw exception through methods with throw()

Stephan Bergmann <sbergman -AT- redhat.com>
Sun, 25 Nov 2012 01:11:21 +0100

On 11/25/2012 12:56 AM, Michael Meeks wrote:


On Sat, 2012-11-24 at 19:04 +0100, Markus Mohrhard wrote:

[1] and [2] fix a crash in calc import that happens if the sax parser
is throwing an exception when reading the document properties.


        Looks great to me - pushed to 3-6- need another couple for -3-6-4.

Looks good to me too (and Markus explained offline to me that returningtrue from ExcelFilter::importDocument in case of catching an exceptionis right indeed).


So one more +1 needed for -3-6-4.

Stephan

Context

[REVIEW 3-6 3-6-4] fix for fdo#57451, don't throw exception through methods with throw() · Markus Mohrhard
- [PUSHED 3-6][REVIEW 3-6-4] fix for fdo#57451, don't throw exception through methods with throw() · Michael Meeks
  - Re: [REVIEW 3-6-4 2/3] fix for fdo#57451, don't throw exception through methods with throw() · Stephan Bergmann
    - Re: [PUSHED][REVIEW 3-6-4 3/3] fix for fdo#57451, don't throw exception through methods with throw() · Noel Power
    - Re: [PUSHED 3-6-4] fix for fdo#57451, don't throw exception through methods with throw() · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.