Re: [REVIEW 3-6] fdo#56548, also remove comment caption objects when deleting comments

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Wed, 21 Nov 2012 15:08:50 +0100

Hey Kohei,


[1] fixes that comment captions are not deleted with the comment. I
checked that undo/redo are memcheck clean as the note caption object
lifetime is not simple.

Regards,
Markus

[1]
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f44928cbd51fc7d08e2b81dcdf837650cd215847



The bug you reference

https://bugs.freedesktop.org/show_bug.cgi?id=56548

doesn't seem related to the bug that this commit fixes... Perhaps a typo?



Yeap sorry, should have been fdo#56584.

Regards,
Markus

Context

[REVIEW 3-6] fdo#56548, also remove comment caption objects when deleting comments · Markus Mohrhard
- Re: [REVIEW 3-6] fdo#56548, also remove comment caption objects when deleting comments · Kohei Yoshida
  - Re: [REVIEW 3-6] fdo#56548, also remove comment caption objects when deleting comments · Markus Mohrhard
    - Re: [REVIEW 3-6] fdo#56548, also remove comment caption objects when deleting comments · Kohei Yoshida
      - Re: [REVIEW 3-6] [PUSEHD 3-6] fdo#56548, also remove comment caption objects when deleting comments · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.