Hi Eike,
I'm currently putting your review into a better patch:
-renaming the functions: I reverted some lines as you proposed.
The link to the help files has been broken, i.e. WEEKNUM now points to
the (partially out of date) help text for WEEKNUM_ADD, but ISOWEEKNUM
does not point to a help text.
That link wasn't broken, the xhp files were not included in the patch. I guess it is beyond the 
scope for git and that I should use ./g instead to include it. Am I correct here?
There are three cases to be considered:
1. reading ODF 1.2 (ODFF)
2. writing ODF 1.0/1.1 (PODF)
3. reading ODF 1.0/1.1 (PODF)
This will need some study from me, poking is not my strongest capabilty.
I will put the latest diff file as an attachment in bug 50950, as I'm afraid the 'poking' will take 
some time.
Winfried
Context
- Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply	with ODFF1.2 (continued)
 
   
 
  Privacy Policy |
  
Impressum (Legal Info) |
  
Copyright information: Unless otherwise specified, all text and images
  on this website are licensed under the
  
Creative Commons Attribution-Share Alike 3.0 License.
  This does not include the source code of LibreOffice, which is
  licensed under the Mozilla Public License (
MPLv2).
  "LibreOffice" and "The Document Foundation" are
  registered trademarks of their corresponding registered owners or are
  in actual use as trademarks in one or more countries. Their respective
  logos and icons are also subject to international copyright laws. Use
  thereof is explained in our 
trademark policy.