Michael Meeks has uploaded a new patch set (#2).
Change subject: fdo51023: Revert e4450c54aee85b295b933e91d207fd8220c01107 for Mac OS X
......................................................................
fdo51023: Revert e4450c54aee85b295b933e91d207fd8220c01107 for Mac OS X
See bug for discussion. Basically, the root cause to the problem is
that on the Mac, all the drag-and-drop action happens during the call
to pSlideSorterViewShell->StartDrag() in the Initialize method. Thus
no wonder that mpDragAndDropContext is null in the ProcessDragEvent()
as it has not been initialized yet, and is in fact initialised
pointlessly only after the drag-and-drop already has finished.
Reverted just for Mac OS X and ifdefified in a straightforward even if
ugly fashion.
Change-Id: Icfb62fb24a5c72fda39c8bcea125267c99ecf624
Signed-off-by: Michael Meeks <michael.meeks@suse.com>
---
M sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx
1 file changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1001/2
--
To view, visit https://gerrit.libreoffice.org/1001
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfb62fb24a5c72fda39c8bcea125267c99ecf624
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot <gerrit@libreoffice.org>
Gerrit-Reviewer: Michael Meeks <michael.meeks@suse.com>
Gerrit-Reviewer: Tor Lillqvist <tml@iki.fi>
Context
- Change in core[libreoffice-3-6]: fdo51023: Revert e4450c54aee85b295b933e91d207fd8220c01107 fo... · Michael Meeks (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.