Re: [Libreoffice-commits] avoid 'else ifeq' construct in make

Stephan Bergmann <sbergman -AT- redhat.com>

Mon, 05 Nov 2012 10:26:29 +0100

On 11/04/2012 02:17 PM, Libreoffice Gerrit user wrote:

commit 198a18b246ac8105cd868138e0ba172f8e83c0d5
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Sun Nov 4 07:13:50 2012 -0600

     avoid 'else ifeq' construct in make

why? Stephan

     Change-Id: I075313f99c88241348a9c1184d1e1a54de6154cc

diff --git a/lpsolve/ExternalPackage_lpsolve.mk b/lpsolve/ExternalPackage_lpsolve.mk
index d63287d..7fcf0c2 100644
--- a/lpsolve/ExternalPackage_lpsolve.mk
+++ b/lpsolve/ExternalPackage_lpsolve.mk
@@ -20,14 +20,15 @@ $(eval $(call gb_ExternalPackage_add_files,lpsolve,lib,lpsolve55/lpsolve55.lib))
  endif # $(COM)
  $(eval $(call gb_ExternalPackage_add_files,lpsolve,bin,lpsolve55/lpsolve55.dll))
  else # $(GUI)
-
  ifeq ($(OS),MACOSX)
  $(eval $(call gb_ExternalPackage_add_files,lpsolve,lib,lpsolve55/liblpsolve55.dylib))
-else ifeq ($(DISABLE_DYNLOADING),TRUE)
+else # $(OS)
+ifeq ($(DISABLE_DYNLOADING),TRUE)
  $(eval $(call gb_ExternalPackage_add_files,lpsolve,lib,lpsolve55/liblpsolve55.a))
-else
+else # DISABLE_DYNLOADING
  $(eval $(call gb_ExternalPackage_add_files,lpsolve,lib,lpsolve55/liblpsolve55.so))
+endif # $(DISABLE_DYNLOADING)
  endif # $(OS)
-
  endif # $(GUI)
+
  # vim: set noet sw=4 ts=4:

Context

Re: [Libreoffice-commits] avoid 'else ifeq' construct in make · Stephan Bergmann

Re: [Libreoffice-commits] avoid 'else ifeq' construct in make · Norbert Thiebaud

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.