Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hey Mathieu,

2012/10/26 Mathieu D. <call.protected@gmail.com>:
Hi,

I submitted a patch for the bug 51309 - Names of DatabaseRanges should not
be case sensitive :
https://bugs.freedesktop.org/show_bug.cgi?id=51309

You will the diff file attached and on the bug's page.
https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=51309&attachment=69115

Changes :

- ScDBData::less::operator() is modified to compare upper strings

- All the calls to NamedDBs::findByName() are now
NamedDBs::findByUpperName().

- In case of a call to findByUpperName by an argument, the function
ScGlobal::pCharClass->uppercase(aName) was used to ensure upper case.

- The definitions of FindByName() are deleted.



The patch looks good. Could you please create the patch with git
commit -a && git format-patch HEAD~1 so that it includes you correctly
as author.

And please could you send a licence statement like:

All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+
dual license.

to the Mailing so list so that we can keep track of it at
http://wiki.documentfoundation.org/Development/Developers

Thanks a lot for your great contribution. Are there any areas that
interest you? Are you interested in more calc hacking?

Regards,
Markus

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.