Re: [PATCH] fdo#42135: Appending a library functionality in Macro Programming missing or misdocumented

On 10/27/2012 10:14 AM, Norbert Thiebaud wrote:
> On Fri, Oct 26, 2012 at 6:47 PM, Norbert Thiebaud <nthiebaud@gmail.com> wrote:
> > > Ah!! but that also means that the automatic commit in the super module
> > > by gerrit will not work anymore... IIRC.
> >
> > Stephan, you may want to revert that... since the hassle of setting up
> > a pushurl once is much less than not being able to manage patch via
> > the review system for submodules...
>
> Indeed until the following patch is released, relative path break the
> auto-managment of submodules by gerrit
>
> https://gerrit-review.googlesource.com/#/c/36190/
>
> so
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e48667f6bdd2f5e05b3f41d080fda06bd3d7c16
> should be reverted until then...
>
> Stephan can you please revert it ?

Ah, I hadn't been aware of this strange connection when I did that 
commit.  I'm actually not convinced at all that gerrit's automatic 
commits are what one generally wants (I at least had at least two 
situations already where I did /not/ want them), but that's another 
story and I happily reverted the above now as 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=12f7e27917cb014dd78e87c38e9698aa5c148114> 
"Revert 'Use relative submodule URLs.'"

Stephan