On Wed, Oct 24, 2012 at 10:10 AM, Stephan Bergmann <sbergman@redhat.com> wrote:
So when you have a core commit A and a submodule commit B that logically
belong together, with the above recipe the end result on the server will no
longer reflect that, as it "ties" B to an "artificial" core commit C
preceding A, instead of keeping B "tied" to A.
the rational here is: pushing in submodule and forgetting a commit in
the super module is a common anti-pattern, so gerrit automate that.
and submodules A and B are presumably independent (the whole point of
submodules was, in their intent to allow for such loosely connected
section of code), so a commit in either should not be related in a
commit to the other.
There may be way around that... but for the rare case where that would
really be useful, It does not seems worth the aggravation.
Norbert
Note: a huge majority of the commit made in submodules by dev outside
of timar(translation) and petr(rel-eng) are actually in binfilter...
which is going to be dropped in the not so far future....
Context
- Re: [Libreoffice-commits] .: 5 commits - config_host.mk.in configure.ac ct2n/delzip ct2n/description-en-US.txt ct2n/Extension_ct2n.mk ct2n/Makefile ct2n/makefile.mk ct2n/Module_ct2n.mk ct2n/prj ct2n/UnpackedTarball_ct2n.mk dictionaries Makefile.top n · Norbert Thiebaud
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.