Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/903

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/903/1

warn free build of dmake, concat-deps and lpsolve

I've added a correct if test to silence compiler warnings like this:
"warning: ignoring return value of 'fread', declared with attribute warn_unused_result"
or
"warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result"

In lpsolve via a new patch:
Moved from  "fprintf(output, (char* variable))" to "fputs((char* variable), output)"
because of a compiler warning that it couldn't varify the format string because it wasn't a
string literal.
and correctly redid the the ECHO macro from '(void)fwrite(...)' to 'do { if(fwrite(...)) {} } 
while(0)'
because it's clear that we tried to cast a size_t to void meaning we do not care about the
return of fwrite in this case.

Change-Id: I1137160d28461fbac69c8e05d32ba010da491c57
---
M dmake/unix/arlib.c
M helpcontent2
A lpsolve/lp_solve-fixed-warn.patch
M lpsolve/makefile.mk
M solenv/bin/concat-deps.c
5 files changed, 87 insertions(+), 6 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/903
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1137160d28461fbac69c8e05d32ba010da491c57
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup <rk.katana.steel@gmail.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.