Re: [REVIEW 3-6-3 1/3] ~ appears in German unix OK/Cancel translations

On Mon, 2012-10-22 at 13:54 +0100, Caolán McNamara wrote:
> In 3.5.7 the German unix OK/Cancel translations visually have ~ in them.
>
> ~ is our accelerator code, and in the last update of the 3.5.7 .de
> translations ~ appears in the .de translations, but we have some unix
> specific code which prepends ~ to the OK/Cancel translations, resulting
> in a double ~
>
> https://bugs.freedesktop.org/show_bug.cgi?id=56281
>
> proposing 920807d4491834cd88e545fdb930c9105d58c4cd for 3-6 and 3-5 to
> protect against this.

It should avoid the problems on Linux and it looks more safe than the
previous code => put back the String->OUString conversion and pushed
into both 3-5 and 3-6 branches:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=1141d04daea3a0091c2d7533018dbe17e5b5a8bd
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=47a8db922ee6980c540c2223be5452bc6b2b2bbb

It would be great to get this into 3-6-3 release. Two more approvals are
needed.

> I'm unsure, reading the comments in the weird vcl code, if there might
> be an additional problem under windows. If someone could check the
> windows German 3.5.7 for problems in OK/Cancel that'd be good, to know
> if we need tooling to disallow ~ in OK/Cancel translations. Or if we can
> remove the platform conditionality.

I hope that Andras will check it once he is back from the SUSE
conference.

Best Regards,
Petr