basobj3.cxx

Ricardo Montania <ricardo -AT- linuxafundo.com.br>
Mon, 15 Oct 2012 16:26:09 +0430

Yes, no problem.

Thanks :)

On Mon, Oct 15, 2012 at 4:06 PM, Jan Holesovsky <kendy@suse.cz> wrote:

Hi Ricardo,

Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +0000:

    https://gerrit.libreoffice.org/851


Thank you a lot for the patch! :-)  Having seen it pushed, I've done a
small follow-up tweak:


http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ad86ef1caaa029b8c95273528afeb724fa6582d

The OUString has a convenience isEmpty() member, that is more obvious
when reading the code than the check for 0 length, would be great if you
can use that in your further patches :-)

All the best,
Kendy



-- 
Ricardo Montania Prado de Campos
http://www.linuxafundo.com.br

Context

[PATCH] Review corrections in basctl/.../basobj3.cxx · Ricardo Montania (via Code Review)
- [PUSHED] Review corrections in basctl/.../basobj3.cxx · Muthu Subramanian K (via Code Review)
- Re: [PATCH] Review corrections in basctl/.../basobj3.cxx · Jan Holesovsky
  - Re: [PATCH] Review corrections in basctl/.../basobj3.cxx · Ricardo Montania

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.