Re: [PUSHED 3-6][REVIEW 3-6-3 2/3] fix for fdo#55734 , don't access index 0 in an empty vector

Eike Rathke <erack -AT- redhat.com>
Thu, 11 Oct 2012 20:17:39 +0200

Hi,

On Thursday, 2012-10-11 15:37:52 +0100, Noel Power wrote:

On 11/10/12 15:03, Noel Power wrote:

On 11/10/12 14:35, Markus Mohrhard wrote:

[1] fixes a crash that happens when we try to access the first element
of an empty vector.

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=132740681c7412f4d678ff0768b9807502525f76


+1 for 3-6-3 ( I see that it is already committed to 3-6 )
Noel

actually I replied to the wrong bug here ( I meant to reply to ' fix
for rhbz#864858' ) but still +1 for this ( I just pushed it to 3.6 )


Another sign-off from me, one more needed for 3-6-3

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack

Attachment: pgpw0rnN8Xtn8.pgp
Description: PGP signature

Context

[REVIEW-3-6 3-6-3] fix for fdo#55734 ,don't access index 0 in an empty vector · Markus Mohrhard
- Re: [PUSHED 3-6][REVIEW 3-6-3] fix for fdo#55734 , don't access index 0 in an empty vector · Noel Power
  - Re: [PUSHED 3-6][REVIEW 3-6-3] fix for fdo#55734 , don't access index 0 in an empty vector · Noel Power
    - Re: [PUSHED 3-6][REVIEW 3-6-3 2/3] fix for fdo#55734 , don't access index 0 in an empty vector · Eike Rathke
      - Re: [PUSHED 3-6][PUSHED 3-6-3] fix for fdo#55734 , don't access index 0 in an empty vector · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.