Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 10/10/2012 11:57 AM, Noel Power wrote:
I'm in two minds whether this should be a MAB, indeed it is annoying ;-)
in anycase I would recommend to please cherry-pick the following revert
http://cgit.freedesktop.org/libreoffice/core/commit/?id=44e8a8240a3a1cce747f1998e617f8dd4621a992

Yup, makes sense. Pushed to 3-6 with my sign-off.

If people think it's worthy of 3-6-3, we need two more sign-offs to push this to 3-6-3.

BTW, we definitely need a test for this case. We already have one test case in testSort() in sc/qa/unit/ucalc.cxx, adding another test case involving empty cells would prevent future regression for this particular use case.

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.