Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/779
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/779/1
cppcheck : redundantCondition. In this case, it seems to be a typo.
Changed the redundant check against fRate with a test against fPrice as
everywhere else in the file.
Also change some comparisons against 0.0 instead of 0 when using floating
point variable (to be consistent with the rest of the code).
Change-Id: I94a397f1578a90156359987996cb1ef02d5e4209
---
M scaddins/source/analysis/financial.cxx
1 file changed, 7 insertions(+), 7 deletions(-)
--
To view, visit https://gerrit.libreoffice.org/779
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94a397f1578a90156359987996cb1ef02d5e4209
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Context
- [PATCH] cppcheck : redundantCondition. In this case, it seems to be ... · Christophe JAILLET (via Code Review)
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.