Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/728
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/728/1
Make Po classes robuster
-Make PoOfstream\PoIfstream classes for
checked po input\output
-Make copyability obvious
-Handle runtime errors with exceptions
-Use assertions to define exceptations
for programmers
Plus some correction
-Use simplier indentation
-In renewpo.cxx, define sdf file as a tempfile
instead of make it in current location
-Use constructor to renew poheader
-Use const where needed
Change-Id: Ic11ce3b9eee9a9fa9fbc4ccda154623160ad9d8a
---
M l10ntools/inc/po.hxx
M l10ntools/source/localize.cxx
M l10ntools/source/merge.cxx
M l10ntools/source/po.cxx
M l10ntools/source/renewpo.cxx
5 files changed, 426 insertions(+), 132 deletions(-)
--
To view, visit https://gerrit.libreoffice.org/728
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic11ce3b9eee9a9fa9fbc4ccda154623160ad9d8a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: feature/killsdf
Gerrit-Owner: Zolnai Tamás <zolnaitamas2000@gmail.com>
Context
- [PATCH] Change in core[feature/killsdf]: Make Po classes robuster · via Code Review
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.