As attached,
I've noticed a number of these straying in. Did we disable a warning on
un-initialized members for some reason ? I could swear the compiler used
to complain helpfully about this.
Thanks,
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
From 23c4a5bf342abdddb3df13c1d8d8f6fc36ecd94a Mon Sep 17 00:00:00 2001
From: Michael Meeks <michael.meeks@suse.com>
Date: Thu, 20 Sep 2012 12:00:11 +0100
Subject: [PATCH] cups: initialize thread running member
Change-Id: Idf8b079857638558075fa6b1fb5f7ea6b3c9f632
---
vcl/inc/cupsmgr.hxx | 2 +-
vcl/unx/generic/printer/cupsmgr.cxx | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/vcl/inc/cupsmgr.hxx b/vcl/inc/cupsmgr.hxx
index f3cee19..d2ae11d 100644
--- a/vcl/inc/cupsmgr.hxx
+++ b/vcl/inc/cupsmgr.hxx
@@ -47,7 +47,7 @@ struct FPtrHash
class CUPSManager : public PrinterInfoManager
{
- boost::unordered_map< FILE*, rtl::OString, FPtrHash > m_aSpoolFiles;
+ boost::unordered_map< FILE*, rtl::OString, FPtrHash > m_aSpoolFiles;
int m_nDests;
void* m_pDests;
bool m_bNewDests;
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx b/vcl/unx/generic/printer/cupsmgr.cxx
index f13b774..616385e 100644
--- a/vcl/unx/generic/printer/cupsmgr.cxx
+++ b/vcl/unx/generic/printer/cupsmgr.cxx
@@ -193,7 +193,8 @@ CUPSManager::CUPSManager() :
PrinterInfoManager( CUPS ),
m_nDests( 0 ),
m_pDests( NULL ),
- m_bNewDests( false )
+ m_bNewDests( false ),
+ m_bPPDThreadRunning( false )
{
m_aDestThread = osl_createThread( run_dest_thread_stub, this );
}
--
1.7.7
Context
- [REVIEW-3-6] trivial cups thread init issue ... · Michael Meeks
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.