Re: [PATCH] i18npool Add locale data for ebo_CG and tyx_CG

Hi Jeremy,

On Wed, Sep 19, 2012 at 10:30:52PM +0100, Jeremy Brown <jeremy.r.brown@gmail.com> wrote:
> This is my first patch submission to LibreOffice or anywhere else so
> let me know if there's something I haven't done right or should do
> differently.  Thanks.

All you need is to submit a license mail what we can link from
http://wiki.documentfoundation.org/Development/Developers, stating:

"All my contributions, past and future, to LibreOffice are licensed
under the terms of the MPL / LGPLv3+."

> + * This file incorporates work covered by the following license notice:
> + *
> + *   Licensed to the Apache Software Foundation (ASF) under one or more
> + *   contributor license agreements. See the NOTICE file distributed
> + *   with this work for additional information regarding copyright
> + *   ownership. The ASF licenses this file to you under the Apache
> + *   License, Version 2.0 (the "License"); you may not use this file
> + *   except in compliance with the License. You may obtain a copy of
> + *   the License at http://www.apache.org/licenses/LICENSE-2.0 .

Is this really based on work from the ASF or you only copied the wrong
license header? See TEMPLATE.SOURCECODE.HEADER in the root directory on
what header to use when the new file is based only on your own work.

> diff --git a/solenv/inc/langlist.mk b/solenv/inc/langlist.mk
> index 5ba2dc8..b35dd20 100644
> --- a/solenv/inc/langlist.mk
> +++ b/solenv/inc/langlist.mk
> @@ -47,6 +47,7 @@ da \
>  de \
>  dgo \
>  dz \
> +ebo \
>  el \
>  en-GB \
>  en-US \
> @@ -127,6 +128,7 @@ tn \
>  tr \
>  ts \
>  tt \
> +tyx \
>  ug \
>  uk \
>  uz \

Hmm, all languages in langlist.mk have a relevant English description in
scp2/source/ooo/module_langpack.ulf. Is it intentional that you left out
the descriptions for these two languages?

Thanks,

Miklos