Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi Michael,

On 09/19/2012 12:40 PM, Michael Meeks wrote:

        This reasonably trivial fix accelerates a large (private) PivotTable
document load from 100seconds down to 20 seconds for me. It dungs out a
chunk of code - I'm doing some more aggressive cleanup on master - to
not hold the entire OLE2 stream in allocated memory while reading ;-)
[ sadly we still do that while writing until 'Commit' ] - but this is
the simpler version for 3-6.

Reviewed it and looks good to me. The only things I've changed are the post-increment iterators to pre-increment in StgCache::Commit().

Pushed to 3-6 with my sign-off.  Thanks a lot for this. :-)

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.