Re: [PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value

Lionel Elie Mamane <lionel -AT- mamane.lu>
Fri, 14 Sep 2012 18:09:44 +0200

On Fri, Sep 14, 2012 at 04:00:15PM +0000, Lionel Elie Mamane (via Code Review) wrote:

    https://gerrit.libreoffice.org/624

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/624/1

fdo#44721 protect against negative calculated height value

Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360



These negative value were causing underflow when converted to
unsigned, and thus a very, very long loop in the drawing code, thus
equivalent to freeze for the user.

-- 
Lionel

Context

[PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value · Lionel Elie Mamane (via Code Review)
- Re: [PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value · Lionel Elie Mamane
- Re: [PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value · Michael Meeks
  - Re: [PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value · Miklos Vajna
- [PUSHED] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value · Michael Meeks (via Code Review)

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.