Re: [PUSHED-3.6][REVIEW--3-5] fix for fdo#54721

Noel Power píše v Út 11. 09. 2012 v 12:02 +0100:
> On 11/09/12 11:12, Petr Mladek wrote:
> > Noel Power píše v Po 10. 09. 2012 v 12:10 +0100:
> > > another nasty bug ( can cause some quite weird side effects with vba )
> > > https://bugs.freedesktop.org/show_bug.cgi?id=54721
> > > fix to cherrypick is
> > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=cea414bfe8fe356793778bdf09f5ca3b3a42daa0
> > Hmm, this one did not helped here in 3-6 branch. 
> I'm afraid it was my fault, the fix that I committed to master was 
> incomplete ( I must have done a git commit . )  because you need 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c29057f55dc1afde8911ac527814ca09ead2c2f

It started to work after I added this one as well.

I was a bit scared by the second commit because lclGetVBAGlobalConstName
started to return another value. Noel explained that the value
VBAGlobalConstantName never existed in LO. The whole problem was caused
by merging some code

=> looks good => pushed into 3-6.

Someone still need to check it on 3-5.


Best Regards,
Petr,