Re: [REVIEW 3-6][REVIEWED] fdo#53938 Prevent crash on pivot table refresh on non-existent data source

Kohei Yoshida <kohei.yoshida -AT- gmail.com>
Thu, 30 Aug 2012 11:21:52 -0400

On 08/30/2012 11:11 AM, Markus Mohrhard wrote:

Hey Kohei,

2012/8/30 Kohei Yoshida <kohei.yoshida@gmail.com>:

I'd like the following two:

https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=286ce144981aaa426622624302e296588abab1c2
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6ad86f8cc036d01702e9d491874b2b3bde23fe77

backported to 3-6 in order to fix

https://bugs.freedesktop.org/show_bug.cgi?id=53938

It's a simple null pointer check, plus additional error checks.  Should be a
safe change.


Looks good and correct to me. Approved for 3-6.


Thanks.  Squashed the two and cherry-picked to 3-6 with your sign-off.

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context

[REVIEW 3-6] fdo#53938 Prevent crash on pivot table refresh on non-existent data source · Kohei Yoshida
- Re: [REVIEW 3-6][REVIEWED] fdo#53938 Prevent crash on pivot table refresh on non-existent data source · Markus Mohrhard
  - Re: [REVIEW 3-6][REVIEWED] fdo#53938 Prevent crash on pivot table refresh on non-existent data source · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.