[PUSHED] Change in core[libreoffice-3-6]: fdo#53968 etc.: Fix more "doesn't start after upgrade" probl...

From Norbert Thiebaud <nthiebaud@gmail.com>:

Norbert Thiebaud has submitted this change and it was merged.

Change subject: fdo#53968 etc.: Fix more "doesn't start after upgrade" problems
......................................................................


fdo#53968 etc.: Fix more "doesn't start after upgrade" problems

* fdo#53968 revealed that multiple soffice.bin instances can run removeTree in
  parallel.  Therefore, demoted failures from exceptions to SAL_WARNs.  (And
  keeping fingers crossed.)

* a8cdce148c76c93c5d41820610d6e6ac175e03a7 "fdo#53655: Ignore failure to remove
  directories (as happens on Windows XP)" was due to a forgotten
  osl::Directory::close before calling osl::Directory::remove after all.

* UserInstallations have been seen in the wild where no extensions were
  installed per-user (any longer), but user/uno_packages/cache/registry/
  com.sun.star.comp.deployment.component.PackageRegistryBackend/*.rdb files
  contained data nevertheless.  To reliably clean out any old junk,
  refreshBundledExtensionsDir has been extended to cleanExtensionsCache which in
  tandem with an extended Desktop::SynchronizeExtensionRepositories now cleanly
  re-installs all bundled, shared, and per-user extensions after a LO upgrade.

Change-Id: Ic6b5b6c1945d76eb3a65b6cd4512a657b7a835a0
---
M desktop/inc/app.hxx
M desktop/source/app/app.cxx
M desktop/source/app/check_ext_deps.cxx
M desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx
M desktop/source/deployment/inc/dp_misc.h
M desktop/source/deployment/manager/dp_extensionmanager.cxx
M desktop/source/deployment/manager/dp_extensionmanager.hxx
M desktop/source/deployment/manager/dp_manager.cxx
M desktop/source/deployment/manager/dp_manager.h
M desktop/source/deployment/misc/dp_misc.cxx
M desktop/source/pkgchk/unopkg/unopkg_app.cxx
M offapi/com/sun/star/deployment/XExtensionManager.idl
M offapi/com/sun/star/deployment/XPackageManager.idl
13 files changed, 179 insertions(+), 121 deletions(-)

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/477
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6b5b6c1945d76eb3a65b6cd4512a657b7a835a0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot <gerrit@libreoffice.org>
Gerrit-Reviewer: Norbert Thiebaud <nthiebaud@gmail.com>
Gerrit-Reviewer: Stephan Bergmann <sbergman@redhat.com>