Re: [PUSHED 3-6][REVIEW 3-6-1 2/3] Fix for fdo#53640 - Pivot table from database source

Hi,

On Wednesday, 2012-08-22 20:22:19 +0100, Michael Meeks wrote:

> On Wed, 2012-08-22 at 15:05 -0400, Kohei Yoshida wrote:
> > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=f4ed9a5adbea3de88870ff4f5cb202bd606e0746
> > cherry-picked to 3-6 and preferably to 3-6-1 as well.  This fixes
>
>       Looks sensible - I'm sure clang would have something to say about this
> sort of incrementing of dead variables ;-)

Michael cherry-picked that to 3-6 as
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=a28d9cad672739cbf8dc6cf1f9db7d0f8becfee1

which has my +1

> > Also, optionally I'd like
> > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=88979ef6ffe7921200311513d6601f9c5d582a42
> >
> > backported as well.  Leaving this code in would result in re-populating 
> > the pivot cache twice unnecessarily, which would degrade performance.
>
>       I pushed that - though it looks more scary.

In 3-6 as
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=257a5fb833c2c03a3a82b19b9ab5a7cb3b5848ef

I can't say much about that without digging into cache/table refreshs
other than having to trust Kohei's judgement. +0.5? ;-)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpm95RUKTDsL.pgp
Description: PGP signature