From Stephan Bergmann <sbergman@redhat.com>:
Stephan Bergmann has uploaded a new change for review.
Change subject: fdo#46249: UCBContentHelper::GetTitle must not fail for void property
......................................................................
fdo#46249: UCBContentHelper::GetTitle must not fail for void property
This was a regression introduced with 2af9040d38af7c7353855415dbea0134585058f3
"Cleaned up utl::UCBContentHelper." GetSize exhibited the same problem and has
also been fixed. IsYounger exhibits a similar problem, but has not been
addressed, as it is unclear what to return in case no dates can be compared; it
is only used in one place (handling SID_EDITDOC in
SfxViewFrame::ExecReload_Impl, sfx2/source/view/viewfrm.cxx) where, it appears,
only contents for which DateModified /does/ yield a non-void value are relevant.
(cherry picked from commit 27c7682e5e5859eb353443d6091143694a56bee8)
Conflicts:
unotools/source/ucbhelper/ucbhelper.cxx
Change-Id: I748745a1d7f361f8f91be87d7356983ee7261b1e
---
M unotools/inc/unotools/ucbhelper.hxx
M unotools/source/ucbhelper/ucbhelper.cxx
2 files changed, 21 insertions(+), 9 deletions(-)
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/452/1
--
To view, visit https://gerrit.libreoffice.org/452
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I748745a1d7f361f8f91be87d7356983ee7261b1e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-5
Gerrit-Owner: Stephan Bergmann <sbergman@redhat.com>
Context
- [PATCH] Change in core[libreoffice-3-5]: fdo#46249: UCBContentHelper::GetTitle must not fail for void... · Gerrit
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.