Re: [REVIEW 3-6][REVIEW 3-6-1] FileStatus can have fewer fields than requested

Michael Stahl <mstahl -AT- redhat.com>
Tue, 21 Aug 2012 13:32:01 +0200

On 21/08/12 13:01, Stephan Bergmann wrote:

Looking into MAB <https://bugs.freedesktop.org/show_bug.cgi?id=46249> 
"CRASH when browse to HD root directory in FILEOPEN Template dialog" 
(which apparently is crashing for yet another, unrelated reason, 
however), I noticed a regression introduced into LO 3.6.0 due to a 
misunderstanding of how osl_getFileStatus is actually working (esp. on 
Windows).

<http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9febb63db2f62cd2b9505dfc4ceb3accc32aecb>
 
"Related fdo#46249: FileStatus can have fewer fields than requested" is 
the (rather trivial) fix for that on master.  Please review for 
backporting to libreoffice-3-6 and libreoffice-3-6-1.  (I see Michael 
already cherry-picked it to libreoffice-3-6.)


+1 from me

Context

[REVIEW 3-6][REVIEW 3-6-1] FileStatus can have fewer fields than requested · Stephan Bergmann
- Re: [REVIEW 3-6][REVIEW 3-6-1] FileStatus can have fewer fields than requested · Michael Stahl
  - Re: [PUSHED 3-6 3-6-1] FileStatus can have fewer fields than requested · Petr Mladek
- [REVIEW 3-6-1] FileStatus can have fewer fields than requested · Michael Meeks

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.