[PATCH][REVIEW 3-6][REVIEW 3-6-1] Create the desktop icon (on Windows) again

Hi Astron,

Attached is a patch that I know you are not too happy about ;-) - change
the default of creating the desktop icon on Windows back to 'yes'.

My reasons for insisting are several; I think I've written most of them
in another mail, but to summarize:

- it is easier to remove the icon than to add it (if you choose an
  option during installation you are not happy with later)
  - even if it is the Administrator who did the installation, the user
    can still remove it from his / her desktop

- others (eg. Firefox) do not even ask, and install the icon

- online update numbers seem to suggest that less people start
  LibreOffice immediately after the installation, compared to when we
  defaulted to installing the start icon; but of course this can be
  totally unrelated

I know that the decisions about the defaults are always hard, and that
is why Andras asked you in the first place, so I don't want just push it
without your approval ;-) - but I believe there are good reasons to
revert the behavior, at least for the near future.

Thank you a lot,
Kendy

From 12f03403fe67c625500f7deb266e3141f7648c73 Mon Sep 17 00:00:00 2001
From: Jan Holesovsky <kendy@suse.cz>
Date: Thu, 16 Aug 2012 18:19:39 +0200
Subject: [PATCH] Revert "fdo#49919 Don't default to desktop pollution"

If somebody made a mistake in his / her preferences during installation, it
is much easier to remove the unwanted icon, than to add it.

This reverts commit 6af68b494dafcc6822463a0445692929735eb0af.
---
 solenv/bin/modules/installer/windows/property.pm |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/solenv/bin/modules/installer/windows/property.pm 
b/solenv/bin/modules/installer/windows/property.pm
index 62919a1..7d4ba0d 100644
--- a/solenv/bin/modules/installer/windows/property.pm
+++ b/solenv/bin/modules/installer/windows/property.pm
@@ -324,6 +324,9 @@ sub set_important_properties
     {
         my $onepropertyline = "DESKTOPLINKEXISTS" . "\t" . "1" . "\n";
         push(@{$propertyfile}, $onepropertyline);
+
+        $onepropertyline = "CREATEDESKTOPLINK" . "\t" . "1" . "\n"; # Setting the default
+        push(@{$propertyfile}, $onepropertyline);
     }
 
     if ( $installer::globals::patch )
-- 
1.7.8.3