Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As

Stephan Bergmann <sbergman -AT- redhat.com>
Thu, 16 Aug 2012 18:22:37 +0200

On 08/16/2012 06:13 PM, Michael Meeks wrote:

        Looks sensible :-) pushed to -3-6 (though I personally loathe burning
two lines of non-renewable vspace for no good reason ;-).

The "{" and "}" lines you mean? I /do/ consider them helpful; spent along time scratching my head just the other day again trying to grokwhat's going on---when all that was going on was a deceivingly formattedsingle-statement if-condition to which another statement had been added(not).

Incidentally, noticed a couple days ago a commit of yours where youremoved such "{" ... "}" lines, in a mumbo rebase commit, so thought itwas likely more a rebasing artifact than deliberate doing. Anyway, Iwould appreciate it if such lines were /not/ removed.


Stephan

Context

[REVIEW 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As · Stephan Bergmann
- [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As · Michael Meeks
  - Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As · Stephan Bergmann
    - Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As · Michael Meeks
      - Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As · Stephan Bergmann
        
        Re: [PUSHED 3-6][REVIEW 3-6-1] fdo#53280: Reset read-only UI after successful Save As · Michael Meeks
    - the inevitable C formatting/brace style flamewar · Michael Stahl
      - Re: the inevitable C formatting/brace style flamewar · Norbert Thiebaud
      - Re: the inevitable C formatting/brace style flamewar · Bjoern Michaelsen
        
        Re: the inevitable C formatting/brace style flamewar · Jean-Tiare LE BIGOT
        
        Re: the inevitable C formatting/brace style flamewar · Bjoern Michaelsen
      - Re: the inevitable C formatting/brace style flamewar · Jan Holesovsky
        
        Re: the inevitable C formatting/brace style flamewar · Lubos Lunak

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.