Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 15/08/12 14:08, Noel Grandin wrote:
Hi

Just when I thought I was done, more of the stuff crawls out.....

These patches pass a full make check.

thanks, pushed

patch #10 has this, which (since the Remove is, uhm, removed) will
delete the same entry multiple times... also previously the elements
were removed at the end, now at the begin

-        if (aList.Count()>nEntryNum) { // maybe still too many entries
-            sal_uIntPtr nTooMuch=aList.Count()-nEntryNum;
+        if (aList.size()>nEntryNum) { // maybe still too many entries
+            sal_uIntPtr nTooMuch=aList.size()-nEntryNum;
             for (sal_uIntPtr nNum=0; nNum<nTooMuch; nNum++) {
                 delete ImpGetEntry(nEntryNum);
-                aList.Remove(nEntryNum);
             }
+            aList.erase(aList.begin(), aList.begin() + nTooMuch);



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.