Re: Need help with adding library dependeny

Hi, Peter,

On Tue, Aug 14, 2012 at 09:09:14PM +0200, Peter Jentsch wrote:
> Hi there,
>
> I've been working on a fix for
> https://bugs.freedesktop.org/show_bug.cgi?id=44969 fdo#44969.
>
> The fix replaces some XSLT constructs that aren't handled well
> performance-wise by libxslt with exslt constructs.
>
> We build and ship libexslt, but don't link against it when building
> libxsltfilter, which breaks the build when building against our internal
> copy of libxslt.
>
> Unfortunately, I'm spoiled by Ant and suffer from severe Make dyslexia,
> so I didn't manage to add that compiler and linker switches myself.
>
> What should I do? I'd rather take a hint and fix it myself, but I could
> also submit a patch to gerrit with a comment asking to fix the build
> problem before pushing.

I have added the necessary infrastructure support for libexslt in commit
ab03e87741f25d3a5532a75c3dc59b5556a2bb24 . All you need to do now is to
use it, like this:

--- a/filter/Library_xsltfilter.mk
+++ b/filter/Library_xsltfilter.mk
@@ -41,6 +41,7 @@ $(eval $(call gb_Library_use_libraries,xsltfilter,\
 ))
 
 $(eval $(call gb_Library_use_externals,xsltfilter,\
+       libexslt \
        libxml2 \
        libxslt \
 ))

D.