[REVIEW 3-6] Fix pivot table import from xlsx (fdo#53456)

Kohei Yoshida <kohei.yoshida -AT- gmail.com>
Mon, 13 Aug 2012 17:16:28 -0400

Hi there,

I'd like

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae296a60781a2b5d5b7523cbda3444e3dd21506f

cherry-picked into 3-6.

This fixes

https://bugs.freedesktop.org/show_bug.cgi?id=53456

The gist of the bug is that, pivot table would treat all formula cellswithin its source range as empty, and the reason was simply because theformula cells were imported *after* the pivot tables wereinitialized...(so they were indeed empty at the time of pivot tableconstruction)

Simply switching the order to put the pivot table initialization afterthe formula cells fixes the problem.

Review and cherry-pick appreciated. I think this one is a pretty safe &simple fix.


Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc

Context

[REVIEW 3-6] Fix pivot table import from xlsx (fdo#53456) · Kohei Yoshida
- Re: [REVIEW 3-6] Fix pivot table import from xlsx (fdo#53456) · Pedro
  - Re: [REVIEW 3-6] Fix pivot table import from xlsx (fdo#53456) · Eike Rathke
    - Re: [REVIEW 3-6] Fix pivot table import from xlsx (fdo#53456) · Pedro
- Re: [PUSHED 3-6] Fix pivot table import from xlsx (fdo#53456) · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.